-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extra css selector to global autofill style -add css class to the… #51117
add extra css selector to global autofill style -add css class to the… #51117
Conversation
42454b8
to
8220bfa
Compare
…d apply web autofill input
ae3e3fd
to
5c0eeae
Compare
@c3024 Do you know what to do about the performance tests check that has failed with this error?
|
Please merge |
…to the platform that this styles are applied for Co-authored-by: Krishna Chaitanya <102477862+c3024@users.noreply.github.com>
…to the platform that this styles are applied for Co-authored-by: Krishna Chaitanya <102477862+c3024@users.noreply.github.com>
…le' into issues/sign_in_dark_autofill_style # Conflicts: # src/pages/signin/SignInPageLayout/index.tsx
Reviewer Checklist
Screenshots/VideosAndroid: NativethemeAndroid.mp4Android: mWeb ChromethemeAndroidmWeb.mp4iOS: NativethemeiOS.mp4iOS: mWeb SafarithemeiOSmWeb.mp4MacOS: Chrome / SafarithemeChrome.mp4MacOS: DesktopthemeDesktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.56-0 🚀
|
… SignInPageLayout to apply sign-in only styles
Details
Add DARK theme CSS styles for auto-fill input in the SignInPage on the web version.
Fixed Issues
$ #50460
PROPOSAL: #50460 (comment)
Tests
Scenario 1.
Scenario 2.
Scenario 3.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2024-10-25.at.12.37.19.PM.mov
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-10-25.at.1.21.03.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-24.at.1.26.23.PM.mov
MacOS: Desktop